Silence extra output on rpmspeq query on Buildsystem specs #3414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnks
reviewed
Oct 30, 2024
|
Heh, funny typo indeed 😄 |
|
Sorry to be that guy... but the commit summary still says rpmspeq 😆 |
Dynamic spec parsing emits "Reading <path>" messages to make it clear something out of the ordinary is going on, but this is undesireable on rpmspec queries. Luckily there's a trivial solution: rpmbuild where you want these messages runs in verbose mode by default whereas rpmspec does not. So just moving the message to INFO level does exactly the right thing in both the above cases. Add a test to go. Fies: rpm-software-management#3413
|
Argh, I didn't even realize there was a second instance 😆 |
|
And don't apologize for spotting typos, there's nothing worse than a typo in a commit message because you can't fix it afterwards and yep, it often makes finding the thing you're looking for much more difficult. |
|
Argh, it really was not my morning: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic spec parsing emits "Reading " messages to make it clear something out of the ordinary is going on, but this is undesireable on rpmspeq queries. Luckily there's a trivial solution: rpmbuild where you want these messages runs in verbose mode by default whereas rpmspec does not. So just moving the message to INFO level does exactly the right thing in both the above cases and as an added bonus, rpmbuild --quiet too. Add a test to go.
Fies: #3413